Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2500

i#2494 ARM encoder: Fix bug in roll-back of reglists.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge i2494-reglist-min into master Jul 05, 2017
  • Overview 8
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: egrimley

Roll-back of greedy reglists was permitted even when the reglist was required to have min_num == max_num. This prevented the encoding of an instruction such as "VTBL.8 d0, {d2-d3}, d4", because it was tried with TYPE_L_VAx3 (list of length 3) before it was tried with TYPE_L_VAx2 (list of length 2). The attempt to use TYPE_L_VAx3 would incorrectly succeed because of the unrestricted roll-back.

The solution used here is to set a field reglist_min_num in the decode_info_t and disallow roll-back beyond that minimum length.

Fixes #2494 (closed)

Change-Id: Id1c22723f7862abc2cf24c0bbab4254b32232b33

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2494-reglist-min