Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C csvkit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 61
    • Issues 61
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • wireservice
  • csvkit
  • Merge requests
  • !939

[csvjson] Support --stream for ND-GeoJSON output; refactorpalooza

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/reidab/csvjson-nd-geojson-stream into master Feb 26, 2018
  • Overview 3
  • Commits 18
  • Pipelines 0
  • Changes 2

Created by: reidab

🌍⏎✨

This adds support for generating newline-delimited GeoJSON output from csvjson with the --stream flag. Both the batch (agate table based) and streaming output modes are supported. As a side effect, --key is also now supported with --stream, but only when --lat and --lon are present.

This PR ended up being a larger refactor of csvjson than I'd expected, teasing apart its main() method into a bunch of extracted parts to avoid duplication. I think the control flow in main() ends up in a much clearer spot, but I'm happy to revise things if this is more of a rewrite than you want to consider.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/reidab/csvjson-nd-geojson-stream