Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C csvkit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 61
    • Issues 61
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • wireservice
  • csvkit
  • Merge requests
  • !604

Simplify (and speed up) the sorting call to agate

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged James McKinney requested to merge sort into master Apr 24, 2016
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 3

Instead of using a lambda in the order_by in csvkit, we could now delegate this to agate. However, csvkit's rule for None was that it is less than everything, but in agate, None is greater than everything. Would this be a breaking change, or can we change the rule?

/cc @onyxfish

Also, note that this PR may fail until agate is released with https://github.com/wireservice/agate/pull/607 merged.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sort