Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C csvkit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 61
    • Issues 61
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • wireservice
  • csvkit
  • Merge requests
  • !126

Choose what quotes to use in the insert feature to avoid the need to escape

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/migonzalvar/master into master Oct 09, 2011
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: migonzalvar

Instead of escape quotes in insert statement generation it tries to use double quotes when single quote are present in the value.

It adds 2 tests with strings containing ' and " and another one to check ASCII extended characters conversion.

Finally, I also changed in test_sql.py make_insert_statement(self) to test_make_insert_statement(self) and fix a method call from _prepare_rows_for_serialization() to to_rows(serialize_dates=True).

I know this is not a fully database specific solution (see #86 (closed)) but IMHO I think it's better than current situation. At least it works, for me :-).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/migonzalvar/master