Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C csvkit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 61
    • Issues 61
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • wireservice
  • csvkit
  • Merge requests
  • !1092

Fixed csvformat's -H/--no-header-row functionality

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/dannguyen/master into master Oct 09, 2020
  • Overview 2
  • Commits 0
  • Pipelines 0
  • Changes 0

Created by: dannguyen

csvformat's test_no_header_row() test seems to be incomplete/non-functional, e.g. it omits the default headers from the expected results:

    def test_no_header_row(self):
        self.assertLines(['--no-header-row', 'examples/no_header_row.csv'], [
            '1,2,3',
        ])

I changed the test to this:

    def test_no_header_row(self):
        self.assertLines(['--no-header-row', 'examples/no_header_row.csv'], [
            'a,b,c',
            '1,2,3',
        ])

And in csvformat.py, I copied the relevant snippet from cli.py:get_rows_and_column_names_and_column_ids() for generating default headers:

https://github.com/dannguyen/csvkit/commit/c4afb6cfb722eac0d7f6d806dc8af85a48251204#diff-5a5d6e33b5e9dc87dbe5b0db33e21e99R53

        reader = agate.csv.reader(self.skip_lines(), **self.reader_kwargs)
        writer = agate.csv.writer(self.output_file, **self.writer_kwargs)
 # new-code
        if self.args.no_header_row:
            # Peek at a row to get the number of columns.
            _row = next(reader)
            reader = itertools.chain([_row], reader)
            headers = make_default_headers(len(_row))
            writer.writerow(headers)
# /new-code
        writer.writerows(reader)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dannguyen/master