Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C csvkit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 61
    • Issues 61
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • wireservice
  • csvkit
  • Merge requests
  • !100

fix for #93

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/thatmattbone/master into master Aug 28, 2011
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 4

Created by: thatmattbone

Two commits here, the first is the pretty straightforward addition of a sniff limit command line arg.

The second is a significantly more questionable way of dealing with kw_args passed to the UnicodeCSVReader. These args are filtered so that only the ones accepted by csv.reader() are passed to it. Because csv.reader is a builtin (I guess implemented in C?), this is done by inspecting csv.Dialect whose attributes specify what can be passed to csv.reader() in a roundabout sort of way. Ultimately this mess is only necessary because I overloaded the CSVKitUtility.reader_kwargs with something that isn't really a reader_kwargs. Maybe it is preferable to to just add something like CSVKitUtility.extra_kwargs? I don't know how this would look.

All of this could be tricky to debug in the future. Also I should try it in something like pypy to see how robust it really is.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/thatmattbone/master