Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C csvkit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 61
    • Issues 61
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • wireservice
  • csvkit
  • Issues
  • #142
Closed
Open
Issue created Jan 18, 2012 by Administrator@rootContributor

Improve csvsql insert performance using a transaction

Created by: migonzalvar

I added a transaction in csvsql.py. Performance for big files improves a lot.

--- a/csvkit/utilities/csvsql.py
+++ b/csvkit/utilities/csvsql.py
@@ -56,8 +56,12 @@ class CSVSQL(CSVKitUtility):
                 insert = sql_table.insert()
                 headers = csv_table.headers()

+                conn = engine.connect()
+                trans = conn.begin()
                 for row in csv_table.to_rows():
-                    engine.execute(insert, [dict(zip(headers, row)), ])
+                    conn.execute(insert, [dict(zip(headers, row)), ])
+                trans.commit()
+                conn.close()

         # Writing to file
         else:

AFAIK, every single SQLalchemy database backend includes transaction support.

Could this little patch be applied to the code? Do you prefer a pull request?

Assignee
Assign to
Time tracking