Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A AndroidSlidingUpPanel
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 267
    • Issues 267
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Umano: News Read To You
  • AndroidSlidingUpPanel
  • Merge requests
  • !857

In SlidingUpPanelLayout.dispatchTouchEvent(), ignore horizontal scrolls

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/hansonchris/hansonchris/horizontalScrollFix into master Aug 14, 2017
  • Overview 9
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: hansonchris

This will allow child views with horizontally scrollable content to behave as expected, regardless of the state of the panel.


My specific issue is this: I have a RecyclerView which has a LinearLayoutManager with a horizontal orientation. This RecyclerView is one of many children inside a ScrollView, and of course, this ScrollView is set as the scrollable view in the SlidingUpPanelLayout.

When the panel was in the COLLAPSED or ANCHORED states, horizontal scrolls on this RecyclerView were awkward. They felt sluggish, and often weren't handled properly.

I would also expect this code change to fix the issue reported in https://github.com/umano/AndroidSlidingUpPanel/issues/679.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/hansonchris/hansonchris/horizontalScrollFix