Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A AndroidSlidingUpPanel
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 267
    • Issues 267
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Umano: News Read To You
  • AndroidSlidingUpPanel
  • Merge requests
  • !585

Have a default state for mLastNotDraggingSlideState

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ivgiuliani/fix-536 into master Nov 16, 2015
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: ivgiuliani

This variable is used to store the saved instance state for the activity, therefore if null will cause he parcel serialization to fail with a NPE. It's not entirely clear to me in what circumstances this can actually happen and I can't reproduce it (even though we see crashes in our crashlytics reports), but there's definitely a code path that leads to the NPE (ss.mSlideState = mLastNotDraggingSlideState at line 1360 in SlidingUpPanelLayout.java).

We've been running this patch internally for a while and we haven't seen any more crashes.

Fixes #536 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ivgiuliani/fix-536