Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !8161

fix bug of issue 8134(Carousel sliding with data-interval="false")

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/liuyl/3.0.0-wip into 3.0.0-wip Jun 13, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: liuyl

This bug is because when we call carousel like $("#content").carousel(), the $.fn.carousel function is called.

But this function does not check the option in HTML attributes, it only extend the option in arguments and the default option. Which means, if we set the data-interval="false", and call $("#content").carousel(), the interval will be set to default value 5000, but not false.

I extend $this.data() to option object. The bug is fixed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/liuyl/3.0.0-wip