Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37141

Define missing "default" `.btn` CSS variables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Snurppa/feature/add-default-btn-hover-x-vars into main Sep 13, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: Snurppa

Buttons that do not specify any variant, did not have all CSS variables defined, such as --#{$prefix}btn-hover-bg. Those were defined only by the button-variant mixins.

Variables of this PR mimic what the button-variant mixins would do (more or less), but applied to so-called "default" .btn (my own terminology invention) with transparent background and, for example, :hover background shaded against $body-bg.

Should not affect anything else, but those using .btn without accompanying .btn-#{$variant}, which most likely is rare...?

Our project happens to use buttons in this obscure way, and noticed something changed in v5.2 release regarding the :hover behavior of our "naked" buttons 😺

Any comments are welcome. Also, I understand if this is seen as unnecessary. But my Inspector would be free of grayish --bs-btn-hover-bg is not defined stains 🙄

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Snurppa/feature/add-default-btn-hover-x-vars