Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36529

Add missing things in `hide` method of dropdown

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Julien Déramond requested to merge v4-dev-dropdown-hide-method into v4-dev Jun 08, 2022
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Gave a try to backport https://github.com/twbs/bootstrap/pull/33451 to v4.

Feel free to modify it directly or close it if it is too far from what's expected here.

I haven't backported the new unit test it('should remove event listener on touch-enabled device that was added in show method', done => { because in v4 there was no existing test in that spirit. In v5 there are tests of EventHandler.off and EventHandler.on but not in v4.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4-dev-dropdown-hide-method