Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36277

Fix proposal for Tooltips

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Louis-Maxime Piton requested to merge github/fork/louismaximepiton/main-lmp-tooltip-fix into main May 04, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Closes #36069 (closed)

Solutions

Thanks to everyone that contributed to the issue, here are the different solutions that came to my mind :

  • @atomiks : Change the CSS to have the expected behavior. (Which is actually implemented in the PR)
  • @GeoSot : Change the js file to have a different behavior which contains some bugs in rare cases imo. (Which modifies the PopperConfig modifier)

I tried for this to modify https://github.com/twbs/bootstrap/blob/51535cd95ac8eb5746e19c057aeabdbcafef3a8b/js/src/tooltip.js#L425 in order to have :

fallbackPlacements: (this._config.placement === 'top' || this._config.placement === 'bottom') ? ['top', 'bottom', 'right', 'left'] : ['right', 'left', 'top', 'bottom']

As the CSS solution seems to do the trick, I didn't explored too much in this way, and the bug remains (just moved away), but I could try to if needed !


Thanks again for the contributors of the issue ❤️

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/louismaximepiton/main-lmp-tooltip-fix