Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35398

Remove extra spaces between navbar brand image and text

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Julien Déramond requested to merge github/fork/julien-deramond/main-jd-navbar-img-text-remove-extra-spaces into main Nov 25, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

While working with navbars, I've spotted something that I think is not here on purpose.

Indeed, this is the line break in the source code that adds a space between the image and the text.

Capture d’écran 2021-11-25 à 16 12 19

If we remove this line break, the string doesn't have anymore those extra spaces and becomes right next to the image: Capture d’écran 2021-11-25 à 16 12 44

This PR is a proposal to align all the content of the <a> and to handle the spacing with a .me-1 (see it in action here)

Another technique would be to do something like that whose I'm not a big fan of:

<a class="navbar-brand" href="#">
  <img src="/docs/{{< param docs_version >}}/assets/brand/bootstrap-logo.svg" alt="" width="30" height="24" class="d-inline-block align-text-top me-1"><!--
  -->Bootstrap<!--
--></a>

Feel free to close this PR if you find it irrelevant or if it is something not very useful to change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/julien-deramond/main-jd-navbar-img-text-remove-extra-spaces