Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !34699

Add check to `rgba-css-var` function for body or bg

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge fix-body-vars-utils into main Aug 05, 2021
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 3

This is the most straightforward fix I can think of for this situation. It's definitely a my bad for not thinking about the new CSS var --body-rgb and there needing to be two separate CSS vars. This PR drops the --bs-body-rgb for two separate ones (so it's a small breaking change), but keeps the .bg-body and .text-body intact without change. it also required duplicating the utilities maps a bit—so we can differentiate at the Sass map level between bg and color. I think this is an acceptable solution, but definitely want to hear thoughts.

Fixes #34688 (closed).

/cc @ffoodd

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-body-vars-utils