Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !34245

Replace `/` division with multiplication and custom `divide()` function

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge drop-sass-division into main Jun 14, 2021
  • Overview 7
  • Commits 4
  • Pipelines 0
  • Changes 15

Fixes #34051 (closed).

This PR aims to resolve the Sass / deprecation issues from Dart Sass. One direction could've been to drop Libsass entirely, using the Dart Sass math module, but that'd effectively ruin any hope for support for Libsass-based projects. That matters not because we want to support something old and deprecated, but because there are dozens if not hundreds of projects that haven't updated to Dart Sass yet. Plus, it's easy enough for us to resolve on our own end without breaking things for others, so why not.

To make this happen, I've replaced the bulk of the division with multiplication, and then used a custom divide() function (thanks @alpadev!) to replace what I couldn't easily switch to multiplication.

Once we get this reviewed and merged, we'll be able to ship v5.0.2.

/cc @twbs/css-review

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: drop-sass-division