Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33947

Refactor scrollbar.js to be used as a Class

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged GeoSot requested to merge gs-refactor-scrollbar-to-class into main May 12, 2021
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 6

Background:

  • First Pr #33245
    • just decoupling scrollbar functionality from modal.js , coping the existing code as it was.
  • Second Pr #33948:
    • scrollbar.js: avoid to create data-bs attributes for null values
    • Revisit modal, offcanvas & scrollbar tests (move scroll tests to scrollbar.spec)

This Pr:

  • sets the base to support different rootElements (than body) helping #33018 and #33574
  • transforms helper to class
  • makes the proper changes to tests
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs-refactor-scrollbar-to-class