Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33149

Revamp accordion borders to fix pixel jumping

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge accordion-schmordion into main Feb 19, 2021
  • Overview 8
  • Commits 3
  • Pipelines 0
  • Changes 2

This should fix the issue once and for all—this takes a simpler approach to the borders and seems to fix all the movement I could see (which was actually visible without even zooming in, at least in Safari).

  • Pushes the borders to the .accordion-item instead of the .accordion-button
  • Simplifies the .accordion-flush's border resets
  • Recreates the .accordion-button's border-bottom with an inset box-shadow
  • Moves the border-radius to the parent, which necessitated the new $accordion-inner-border-radius variable

Fixes #32250 (closed), closes #32251.

Preview: https://deploy-preview-33149--twbs-bootstrap.netlify.app/docs/5.0/components/accordion/

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: accordion-schmordion