Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33136

Adjust `SAFE_URL_PATTERN` regex for use with test method of regexes.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/nikonthethird/fix-33124 into main Feb 17, 2021
  • Overview 7
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: nikonthethird

Recently, the method used to check attributes in the sanitizer has been switched from match to test.

The test method on regexes however behaves different than the match method on strings in the presence of the global modifier (g). See here for an example where the same input returns true, then false.

This modifier causes issues when the same template is sanitized multiple times, which happens when hovering over tooltips containing an <img src> tag for example.

This PR also adds a unit test for sanitizing the same template twice.

This fixes #33124 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/nikonthethird/fix-33124