Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31993

Remove explicit heights on form elements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge main-mc-remove-heights into main Oct 27, 2020
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 4

Created by: MartijnCuppens

Input heights were initially added in https://github.com/twbs/bootstrap/pull/26820 to fix https://github.com/twbs/bootstrap/issues/18842. Select heights were added to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1560824.

But:

  • The additional height in https://github.com/twbs/bootstrap/pull/26820 was caused by pseudo elements, something I fixed in https://github.com/twbs/bootstrap/pull/30269.
  • In the meantime the select issue in FF is changed when you explicitly set the line height (https://bugzilla.mozilla.org/show_bug.cgi?id=1560824#c14), making setting the height redundant

However, removing the explicit height would reintroduce https://github.com/twbs/bootstrap/issues/23307. Luckily, date inputs have a ::-webkit-datetime-edit of which we can set the height in em 🎉

This means, we can safely remove those (min-)heights that seem to cause some issues like https://github.com/twbs/bootstrap/pull/26820#issuecomment-565485267 or https://github.com/twbs/bootstrap/pull/31955#issuecomment-716101054 (this fixes issues when zoomed in/out)

I've kept a min-height for textareas, to keep support for https://github.com/twbs/bootstrap/pull/29124

I didn't apply this change to .form-file, since this will introduce conflicts with https://github.com/twbs/bootstrap/pull/31955, therefor I'll keep this in draft.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-mc-remove-heights