Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31728

Switch to dart-sass

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged XhmikosR requested to merge main-xmr-dart-sass into main Sep 23, 2020
  • Overview 2
  • Commits 4
  • Pipelines 0
  • Changes 3

This is something we've been discussing internally for some time now.

Things to note:

  1. dart-sass's precision is hardcoded to 10; I dropped it down to 6 for the minified files, but we might want to reconsider this and just go with the default? I need to check how much it adds, though
  2. dart-sass orders grouped selectors differently; I have not found a way to work around this and perhaps we should ask upstream. Do note that the minified files keep the old behavior since clean-css sorts the grouped selectors alphabetically
  3. dart-sass converts escaped UTF-8 characters which in turn means we need a @charset "UTF-8";. Not the end of the world, but it is something to note. Also, note that there's a --no-charset flag, but then this could be dangerous since we do have Unicode characters, so we better not use it
  4. dart-sass removes quotes from attribute selectors; not a big deal since they are already removed in the minified files
  5. dart-sass adds leading zeros; again, not a big deal since they are already removed in the minified files
  6. other minor output differences like whitespaces

@twbs/css-review for discussion


  1. Check the bundlewatch size differences
  2. Live preview: https://deploy-preview-31728--twbs-bootstrap.netlify.app/
  3. Test that sourcemaps work properly; I see some changes in soucemaps' sources property

Refs #29853

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-xmr-dart-sass