Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30742

Update to `@rollup/plugin-babel`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged XhmikosR requested to merge master-xmr-rollup-babel into master May 05, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 7

Fixes #30683 (closed)

Changelog: https://github.com/rollup/plugins/blob/master/packages/babel/CHANGELOG.md#500

Removed externalHelpers & runtimeHelpers options. There is now a single babelHelpers option which can take one of 'bundled', 'inline', 'runtime' and 'external' as a value. The default is 'bundled' which matches 4.x behavior, but it is recommended to configure this option explicitly.

So, apart from changing the import, I also had to adapt to the babelHelpers helper option.

Also, I removed the plugins option in js/tests/karma.conf.js since we already have this in our .babelrc.js in root, but we need to confirm if it's being discovered automatically.

TODO:

  • Verify all builds are the same
  • Verify that .babelrc.js is discovered and used by karma
  • Backport this in v4-dev
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-xmr-rollup-babel