Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !28698

Reboot & Type cleanup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge master-mc-reboot into master Apr 27, 2019
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 3

Created by: MartijnCuppens

  • Line height & font family from html were directly overridden by body, so I removed those
  • The remaining properties are moved to body
  • Shim for IE10 tags removed
  • hr cleanup
    • Combined styles from reboot & _type.scss
    • Changed from borders to background
      • This allows us to keep the color inherited.
      • Opacity can be used to change the intensity
      • Size attribute will change the height instead of making the hr look like an input field
    • Better variable names
  • headings cleanup
    • Moved all element styling to reboot. This was actually a bug because before our docs claimed we had different font sizes for headings
    • _type.scss will now extend the element styling. This way we will save some redundant code
  • small & mark are also moved to reboot. _type.scss does not contain any element styling anymore
  • font weight removed from small, this did not really made sense
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-mc-reboot