Skip to content
GitLab

Replace holder.js with inline SVG

Merged Administrator requested to merge v4-dev-martijncuppens-placeholders into v4-dev

Created by: MartijnCuppens

Replaces holder.js with a non-JavaScript solution.

Holder.js is still used on the example pages, that's why I didn't remove it yet. Merging #27605 could could make it easier to remove.

Wow, now I see @m5o did a similar PR a few hours ago

TODO:

  • Use this in examples too
  • Make highlight code not show the svg but instead an img tag
  • Always add the <title>?
  • Remove holder.js when everything else is ready
  • Maybe find another way so that we don't include docs.min.css in examples
  • Do we even need viewBox?
  • Make sure text is big in smaller screens too
  • Clean up/squash some patches before merging

Closes #27632 by superseding it and fixes #23185 (closed) along the way.