Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !26416

Simplify custom file inner height for generated browse button

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge custom-file-height-inner into v4-dev Apr 29, 2018
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Closes #25724 which had us doing more unnecessary math:

-  height: calc(calc(2.25rem + 2px) - 1px * 2);
+  height: calc(2.25rem + 2px - 1px * 2);

By instead extending the $input-height-inner variable:

-  height: calc(calc(2.25rem + 2px) - 1px * 2);
+  height: 2.25rem;

Fixes #25717 (closed).

/cc @MartijnCuppens

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: custom-file-height-inner