Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !2212

Active link to modal div when scrollspy is used fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tagliala/modal-scrollspy-fix into 2.0.2-wip Feb 23, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: tagliala

Dear all,

I found a wrong behaviour when using both modals and scrollspy in the same navbar.

If you put in a navbar a link to a modal - let's say to #myModal - and scrollspy enabled, the #myModal link is rendered as active.

This edit prevents the scrollspy plugin to check for links to modal divs, replacing line 50 of js/bootstrap-scrollspy.js with

return /^#\w/.test(href) && $(href).length && !($(this).attr('data-toggle') == 'modal') ? href : null

Maybe a better solution is possible

Best Regards

GT

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tagliala/modal-scrollspy-fix