Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21473

v4: Rewrite progress component without <progress> element

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge rewrite-progress into v4-dev Dec 29, 2016
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 6

This rewrites the entire .progress component to solve a number of issues with the <progress> element. <progress> elements don't allow animation, cannot have labels overlaid, don't support multiple bars, etc.

Here's what's changes:

  • Revamps CSS to use something more similar to v3's implementation. Far simpler CSS here.
  • Ditches variant mixin for .bg- utils.
  • Rebuilds docs to match, including adding a new Height section for customizing that.

Fixes #17148 (closed), fixes #18835 (closed), closes #18812 (closed), and helps with #21472 (closed).

Only potential remaining todo is adding .sr-only instances to within the bar. Unsure if that's necessary. Thoughts on that @patrickhlauke? Feel like looking at the aria labels we should be able to avoid that, but maybe not?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rewrite-progress