Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21167

Suppress spacebar keyup for dropdowns

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/michaeldrotar/firefox-dropdown-fix into v4-dev Nov 19, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: michaeldrotar

Firefox and Chrome both fire click events when the spacebar is released on a <button>; however, Chrome suppresses this event if preventDefault is called from the keydown handler and Firefox still fires it so it must be explicitly prevented from the keyup as well to get them both working the same.

Alternatively, could change the dropdown to work with the keyup event instead of keydown but I took this approach as it seemed less destructive with existing code.

Fix for issue https://github.com/twbs/bootstrap/issues/21159

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/michaeldrotar/firefox-dropdown-fix