Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !16852

use line-height to compute margin for radios & checkboxes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/AlexErmer/master into master Jul 20, 2015
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: AlexErmer

If you change the default settings which affect the lineheights, the radios and checkboxs aren't aligned properly to its labels. With this change, a dynamic is added to fix this issue.

Its not that pretty, because I have to use 13px as a default height for checkbox and radios (which applies at least to current FF and Chrome versions). Maybe anyone has a better solution for that?

Examples

here are some example screenshots to show the issue and the solution:

first the unchanged default

default

here the default with the fix: remains almost unchanged

default_fixed

now an example with @font-size-base: 20px; and @line-height-base: 1.828571429;

big_default

and here with my fix

big_fixed

and again with small with @font-size-base: 10px; and @line-height-base: 1.228571429;

small_default

and with the fix

small_fixed

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/AlexErmer/master