Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13718

Tooltip arrow fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/peterjwest/tooltip-arrow-fixes into master Jun 03, 2014
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: peterjwest

This fixes two bugs in the tooltips plugin:

  • The tooltip arrow orientation was chosen using the truthiness of the delta.left value returned by getCalculatedOffset, however there are cases when this value is 0, but the placement of the plugin is still top or bottom, which means the arrow should be positioned using the left property. This fix uses the existing placement variable (fixes #13696 (closed))
  • If the page layout changes after the tooltip has been shown, the tooltip orientation could change, in which case the alternate CSS property was never reset (couldn't find an existing issue for this)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/peterjwest/tooltip-arrow-fixes