Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13602

auto determine transition durations

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Harris-Miller/transitionAutoDurations into master May 15, 2014
  • Overview 0
  • Commits 14
  • Pipelines 0
  • Changes 7

Created by: Harris-Miller

this is very similar to pull request #13286 what @tdolsen did there is change .emulateTransitionEnd to take either a number or a string. if you pass in a number, it acts the same as before. if you pass in a string (presumably one from $el.css('transition-duration'), thus giving you "2s" or "2s, 3s", etc) it will parse those, determine which is the greatest, and return that value in milliseconds

now that's a great start to fixing .emulateTransionEnd, however it leaves out 2 key factors

  1. it does not take into account if transition-delay is not zero
  2. you have to keep track of your css transition times in your javascript

i figured that because in practice you would always be calling .emulateTransitionEnd on an element with a transition, we can just fetch the duration and delays times right from the element using $.fn.css

this way we no longer have to pass what the supposed transition time to .emulateTransitionEnd, so when we make changes to those transition in css, we don't have to worry about making changes to our js as well

and second, obviously, i'm taking into account both duration and delay

i'm made changes to transition.js, implementing what i explained about, and also removed the arguments for all location that .emulateTransitionEnd is calls

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Harris-Miller/transitionAutoDurations