Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11851

Add simple same-height columns to the grid with flexbox

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/pete-otaqui/master into master Dec 12, 2013
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 8

Created by: pete-otaqui

Added very simple same-height columns support using the flexbox layout module.

This supports the standard xs, sm, md, lg breakpoints and requires the .row and .cols to have an additional class, like so:

<div class="row row-md-flex">
  <div class="col-md-6 col-md-flex">Short</div>
  <div class="col-md-6 col-md-flex">Tall<br />Tall<br />Tall<br />Tall<br /></div>
</div>

The current W3C CR for flexbox is supported by all modern browsers according to caniuse.com/flexbox, with some vendor prefixing for mobile browsers (Firefox and IE) and Safari (desktop and mobile).

I've added an example to the grid/index.html file, although this needs to be made nicer. I also didn't really have time to understand the best way to use the current less mixins to generate the classes correctly, so I think that could be improved as well.

I'd love to see same-height columns in BS, and I hope that this PR can at the very least start a discussion about it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pete-otaqui/master