Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !10676

Decouple type styling from html

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/colmtuite/decouple-type--styling-from-html into master Sep 17, 2013
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: colmtuite

Visual styles should never be applied directly to HTML elements. They should always be applied with class names.

The size of my headings shouldn't be determined by which HTML element they use. I should be able to apply any heading size to any h tag.

This was possible by using classes .h1 through .h6 but those aren't semantic classes. Applying the .h2 class to a h6 tag suggests that I want my h6 heading to look like a h2 heading. But what should a h2 heading look like?

Using classes like .large, .medium, .small is much more semantic. Just like Bootstrap's buttons.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/colmtuite/decouple-type--styling-from-html