Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !10022

Proposal - Fixed width for glypicons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/thomaswelton/proposal-glyphicon-block into master Aug 22, 2013
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: thomaswelton

The problem… Before the Glyphicon font file has loaded elements using glypicons have no width defined. Then once the font loads the elements grow and move other items around the page. This issue is exacerbated when after the elements grow they cause text to go onto new lines.

The proposed fix - Add a defined width of 1em to all :empty glyphicons

Demo of the problem http://9a6c381b6ab68b16ed63-5b5693321d576aeab3f1767c0caf2c60.r44.cf3.rackcdn.com/ Demo of the proposed fix http://9a6c381b6ab68b16ed63-5b5693321d576aeab3f1767c0caf2c60.r44.cf3.rackcdn.com/fix.html

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/thomaswelton/proposal-glyphicon-block