Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #24167
Closed
Open
Issue created Sep 29, 2017 by Administrator@rootContributor

Unnecessary use of jQuery global

Created by: thheller

It seems to me that bootstrap still has an artificial dependency on the jQuery global that seems unnecessary.

At the top of the file jquery is imported but then the jQuery global is used. https://github.com/twbs/bootstrap/blob/a4667be152a3a4fed4e42f2a9efbf831bb5946b6/js/src/index.js#L1

But then the "check" uses the global https://github.com/twbs/bootstrap/blob/a4667be152a3a4fed4e42f2a9efbf831bb5946b6/js/src/index.js#L21-L32

This pattern is repeated in other files as well, the top imports jquery as $ but then uses jQuery in code. Should it not use $ instead?

I'm asking from a build tool perspective which wouldn't have any issues if the imported object was used instead of the global?

Assignee
Assign to
Time tracking