Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #24090
Closed
Open
Issue created Sep 25, 2017 by Administrator@rootContributor

Button hover colors should be in _variables.scss file

Created by: mwentz

The mixin for button-variant is defined like this:

@mixin button-variant($background, $border, $active-background: darken($background, 7.5%), $active-border: darken($border, 10%))

Because of this, if you want to have the active background 10% darker or 7.5% lighter (for example) you either have to change the mixin file or write more custom css. This could be easily fixed:

/mixins/_buttons.scss

@mixin button-variant($background, $border, $active-background, $active-border)

_variables.scss

$active-background: darken($background, 7.5%);
$active-border: darken($border, 10%);

It looks as though this was probably the original intent, but somebody forgot to move those variables out of the mixin file.

Assignee
Assign to
Time tracking