Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #1939
Closed
Open
Issue created Feb 13, 2012 by Administrator@rootContributor

Actual help texts are rendered as error, warning, success etc.

Created by: dyve

When a form is styled with form control states (http://twitter.github.com/bootstrap/base-css.html?#forms, scroll down a little), all help texts (both help-inline and help-block) take their styling from the control state (error, warning, etc).

However, the example fails to take regular help text into account.

With the current version of Bootstrap, any help text within a control-group with a state class is styled as if it is part of the error message, which is wrong. The help text should be styled as what it is, a help text. The underlying issue here of course is that the messages are using the classes for help.

I made a small demo of the official Bootstrap example with added help-block p's with regular help text. I hope this illustrates the problem:

http://jsfiddle.net/TE7HK/1/ (same goes for help-inline)

I see two possible solutions.

  1. Make a difference between help-inline/help-block and message-inline/message-block. Messages are styled like help texts, but take their colors from a surrounding control-group.error class. This would break compatibility with 2.0.0 as far as colors go, but not the actual display of items. Also, it would introduce 2 new classes (message-inline, message-block).
  2. Add the option to define a help-block and help-inline with an extra class "help", which makes them unaffected by surrounding error, warning, etc.

e.g.

<p class="help-block">I will take the color from my control state. If there isn't any, I'll be styled like help.</p>
<p class="help-block help">You won't see mee turn red because of an error!</p>
<p class="help-block error">I will always be displayed as an error text, regardless of the control state.</p>

After writing this up, I'm in favor of solution #2 (closed).

Assignee
Assign to
Time tracking