Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !880

Use SVG `symbol` for icon system

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge tg-icons into master May 10, 2017
  • Overview 20
  • Commits 1
  • Pipelines 0
  • Changes 15

Created by: tysongach

By using the SVG symbol element along with use, we gain:

  • Not having to run images through the generator.
  • Not having to manage a list of each image to precompile in engine.rb.
  • Not having to maintain a custom application helper.
  • The ability to add title and desc elements to each SVG when we call on an icon, which allows us to contextually add accessible names and descriptions.

Ref: https://css-tricks.com/svg-symbol-good-choice-icons/

There should be no visual changes.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tg-icons