Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !379

CSS Refactor

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge tg-css-refactor into master Jan 06, 2016
  • Overview 4
  • Commits 14
  • Pipelines 0
  • Changes 32

Created by: tysongach

This PR is more improvements to Administrate’s stylesheets architecture. It’s a continuation of #347.

  • Administrate’s stylesheets directory is now more organized and clear:
    • base – all styles for base HTML elements (no classes, id’s, etc.)
    • components – the majority of styles, these are all of our components that create the Administrate design
    • library – any non-rendering Sass, e.g. variables and mixins
    • application.scss – the main Sass manifest, which imports all of the individual Sass partials
  • De-variablized some CSS value that didn’t gain much value from being a variable
  • More closely aligned to thoughtbot’s SCSS style guide; running scss-lint is down to one warning now (which is an edge case)
  • All changes in this PR are mostly structural and do little to change visual design
  • Plus much more!
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tg-css-refactor