Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • N node-http-proxy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 482
    • Issues 482
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • http ... PARTY!
  • node-http-proxy
  • Merge requests
  • !98

Memory leak hunting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/isaacs/master into master Aug 30, 2011
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: isaacs

We saw the memory usage of the http proxy servers in no.de climb way up past normal levels after fixing the crash-inducing socket termination throws. (Incidentally, that error was preventing this one from occurring.)

The attached patch makes sure to destroy the buffered request, and unhook event listeners, when there is an error. So far today, the memory usage on the proxy with this patch has been stable. The others continue to rise, occasionally hitting the point where they get forcibly HUP'ed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/isaacs/master