Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G gulp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gulp
  • gulp
  • Merge requests
  • !2306

Explicitly run coveralls step

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/damccorm/patch-1 into master Mar 20, 2019
  • Overview 15
  • Commits 3
  • Pipelines 0
  • Changes 4

Created by: damccorm

This will allow the token to be passed on PRs in without concern of it being stolen by a changed script. Without this, an attacker could change the npm run coveralls command in package.json in their PR so that it does something bad (e.g. sends them the token).

See https://github.com/gulpjs/gulp/pull/2299#issuecomment-475003985

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/damccorm/patch-1