Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G gulp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gulp
  • gulp
  • Merge requests
  • !104

End dest stream only when underlying resources are closed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Nicolas Froidure requested to merge github/fork/nfroidure/dest-close into master Jan 07, 2014
  • Overview 11
  • Commits 5
  • Pipelines 0
  • Changes 3

I found a very strange issue when comparing the result to the expected one here: https://github.com/nfroidure/gulp-iconfont/blob/master/tests/tests.mocha.js#L31 , it fails due to a different content.

I found this is due to the fact the system write was not completely performed when i tried to access the file content.

I think that continuing after a file.dest should be sure, that's why i suggest to wait the complete underlying resources close before passing the file throught and ending the file.dest returned stream.

The following change solves the issue.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/nfroidure/dest-close