Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7860

Mark TypeScript as an optional peer dependency for react-scripts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/dstaley/patch-1 into master Oct 21, 2019
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: dstaley

This PR adds TypeScript as an optional peer dependency for react-scripts. This modification is necessary to get react-scripts working with Yarn v2, and will enable the TypeScript template for create-react-app to work with Yarn v2.

This PR uses the peerDependenciesMeta key, which signifies to Yarn that typescript is an optional dependency. npm will support the key in the future, in which case "typescript": "*" can be added to peerDependencies. Until that change is made, simply having peerDependenciesMeta will be enough for Yarn, and won't adversely impact users of npm.

Other relevant issues: yarnpkg/berry/pull/475

/cc @iansu

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dstaley/patch-1