Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3323

Handle process stdin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Kjir/handle-process-stdin into master Oct 25, 2017
  • Overview 10
  • Commits 5
  • Pipelines 0
  • Changes 7

Created by: Kjir

This PR continues the work started in #1754 so that it might be merged.

I rebased the changes on top of master (which should fix the test errors, hopefully) and I created the helper in react-dev-utils as suggested in the previous code review.

I tested that it still works with a very simple python program:

import time

time.sleep(10)

After 10 seconds the program does actually quit, both when watching test and when running the dev server.

I am not sure there is a suitable way of adding a test for this, if I receive some suggestions about this I will gladly implement them!

Fixes #1753 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Kjir/handle-process-stdin