Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !11164

Upgrade sass-loader to ^11.1.1

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/BrodaNoel/upgrade-sass-loader-dependency into main Jun 30, 2021
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: BrodaNoel

Why

  • Fix https://github.com/facebook/create-react-app/issues/10944

I couldn't find any test to check if something is wrong. I don't see that much usage of sass-loader, which may implies that this change doesn't break anything.

The problem here is that sass-loader v11 upgrades node-sass from v5 to v6, which removes support for Node v10, which is a problem for CRA because the documentation says that it supports => 10.16

Deeper explanation in https://github.com/facebook/create-react-app/issues/10944#issuecomment-869760083

Feel free to reject this PR if I'm missing something. Everything ran too smooth. It feels weird that works on the first try

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/BrodaNoel/upgrade-sass-loader-dependency