Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1101

Add runtime error overlay

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Timer/redbox into master Nov 26, 2016
  • Overview 263
  • Commits 124
  • Pipelines 0
  • Changes 5

Created by: Timer

If you would like to help, please see https://github.com/facebookincubator/create-react-app/issues/1129.


This PR is a prototype implementation for #783 (closed) which hopefully gets the ball rolling.

This is by no means a complete or even polished proposal, but simply a WIP to track the ongoing discussion in #783 (closed) as it unfolds. There is much to be done for DX and message clarity when the Error object is unavailable or unparsable.

Errors

Errors are captured using window.onerror. window.onerror provides the Error object in most all modern browsers: Chrome 46(?), Firefox 31, IE 11, and Safari 10(ref). Notably, support is missing from Microsoft Edge (unverified, see here -- can someone test this please?).

Unhandled Rejections

Unfortunately, there seems to be no standard/proper way to capture unhandled rejection -- Chrome seems to be the only browser doing this, exposed via the unhandledrejection event. Does anyone have any ideas on how to accomplish this / should it be a Chrome only feature?


Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Timer/redbox