Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !10994

updating src/setupTests.js example

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jacobpatterson1549/patch-1 into main May 20, 2021
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: jacobpatterson1549

Updating the assignment localStorageMock to the 'global' object in example.

The mock object is not set correctly when the assignment operator ('=') is used. When running the test below with the previous 'src/setupTest.js' example, I get the error "window.localStorage.getItem.mockReturnValue is not a function." When 'Object.defineProperty' replaces the assignment in 'src/setupTest.js,' the test passes.

import '@testing-library/jest-dom';
import { render, screen } from '@testing-library/react';

it('should get the item', () => {
    const MockComponent = () => (
        <p>{global.localStorage.getItem('test')}</p>
    );
    const expected = 'juicy';
    global.localStorage.getItem.mockReturnValue(expected);
    render(<MockComponent />);
    const element = screen.getByText(expected);
    expect(element).toBeInTheDocument();
    expect(global.localStorage.getItem).toBeCalled();
});
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jacobpatterson1549/patch-1