Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #12456
Closed
Open
Issue created Jun 01, 2022 by Administrator@rootContributor

`eslint-config-react-app` should provide `@babel/plugin-syntax-flow` and `@babel/plugin-transform-react-jsx`

Created by: CharlesStover

Describe the bug

Installing eslint-config-react-app results in these two warnings:

➤ YN0002: │ eslint-config-react-app@npm:7.0.1 [41989] doesn't provide @babel/plugin-syntax-flow (pc2f30), requested by eslint-plugin-flowtype
➤ YN0002: │ eslint-config-react-app@npm:7.0.1 [41989] doesn't provide @babel/plugin-transform-react-jsx (p4cc0d), requested by eslint-plugin-flowtype

Environment

Yarn 3

Steps to reproduce

  1. yarn install

Expected behavior

eslint-config-react-app should correctly depend on @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx

Actual behavior

Warning


The fix for this is either too add @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx to the dependencies of eslint-config-react-app's package.json file or to its peerDependencies. I didn't know which is desired between the two (I assume peerDependencies, but I know ESLint can be finicky about nested dependencies), so I didn't want to cut a PR with the wrong change.

Assignee
Assign to
Time tracking