Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #11844
Closed
Open
Issue created Dec 26, 2021 by Craig P Hicks@craigphicks

12.0.0 react-dev-utils/openBrowser.js/startBrowserProces bug => BROWSER env value ignored

Describe the bug

[email protected] function startBrowserProcess is calling npm package open function open with wrongly shaped parameter.

Detected on LinuxOS.

Call from react-dev-utils/openBrowser.js/startBrowserProcess to open/open(url,options) is using wrong form for the options parameter. As a result, when using environment variable BROWSER, that value gets ignored and the default browser is opened instead.

react-dev-utils/openBrowser.js/startBrowserProcess

    var options = { app: browser, wait: false, url: true };
    open(url, options).catch(() => {}); // Prevent `unhandledRejection` error.
    return true;

The value of browser is the BROWSER env value, but the property app should be an object

{name: browser}

instead. Here are the usage examples provided by the open npm package page:

// Opens the URL in a specified browser.
await open('https://sindresorhus.com', {app: {name: 'firefox'}});

// Specify app arguments.
await open('https://sindresorhus.com', {app: {name: 'google chrome', arguments: ['--incognito']}});
Assignee
Assign to
Time tracking