Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !882

Place MANIFEST.MF as the second entry of built jars

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/shs96c/jars into master Sep 15, 2016
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 4

Created by: shs96c

JarInputStream.getManifest() only looks at the first two entries of a zip to find the manifest. The way buck builds jar files meant the manifest was the last entry in the zip and that's clearly Not Right.

This diff also means we correctly merge manifest sections, rather than using a "last in wins" approach.

Finally, we now read manifests from directories & not just zip files.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/shs96c/jars